hyperstack-org / hyperstack-org/hyperstack
QueuedMessages from unsent/expired Connections are getting left in the database
未關閉
performance
- 主要語言
- JavaScript
- 星號
- 538
- 分支
- 41
- PR 合併指標
- 30 天內沒有已合併 PR
描述
Lately I've noticed poor performance in our production database for the Hyperstack tables, and noticed we had about 400K QueuedMessages in the table. Upon looking in the code, I found this:
```ruby
# hyper-operation/lib/hyper-operation/transport/connection.rb:111
expired.delete_all
# hyper-operation/lib/hyper-operation/transport/connection.rb:173
inactive.delete_all
```
ActiveRecord `delete_all` does not run callbacks, so the dependent QueuedMessages are not being destroyed when the Connection is. This should be changed to `destroy_all` so that the QueuedMessages don't get left in the database and accumulate.
貢獻指南
評估
這個 Issue 還沒有評估資料。