hyperstack-org / hyperstack-org/hyperstack

The DIV generated by the top level component error handler should have a class

未關閉
#308 0 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視
enhancement good first issue
主要語言
JavaScript
星號
538
分支
41
PR 合併指標
30 天內沒有已合併 PR

描述

In order easily style the top level component error handler back stop it should have a class (like ''hyperstack-top-level-error-boundry' that you can set the CSS for.

I.e. make the text smaller, and give it a white background, etc.

Here is a patch:

```ruby
module Hyperstack
class Hotloader
module AddErrorBoundry
# don't attempt the alias unless the method is defined.
# for example if HotLoader is not included in the stack
alias original_display_error display_error if method_defined? :display_error
def display_error(*args)
DIV(class: 'hyperstack-top-level-error-boundry') { original_display_error(*args) }
end
end
end
end
```

**Be sure to have the method_defined? guard defined, otherwise you may discover in test or worse in production things won't boot**

貢獻指南

開啟貢獻指南

評估

這個 Issue 還沒有評估資料。

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。