hyperstack-org / hyperstack-org/hyperstack

The DIV generated by the top level component error handler should have a class

Aberta
#308 0 comentários 0 reações 0 responsáveis Ver no GitHub
enhancement good first issue
Linguagem predominante
JavaScript
Estrelas
538
Forks
41
Métricas de merge de PRs
Nenhum PR com merge em 30d

Descrição

In order easily style the top level component error handler back stop it should have a class (like ''hyperstack-top-level-error-boundry' that you can set the CSS for.

I.e. make the text smaller, and give it a white background, etc.

Here is a patch:

```ruby
module Hyperstack
class Hotloader
module AddErrorBoundry
# don't attempt the alias unless the method is defined.
# for example if HotLoader is not included in the stack
alias original_display_error display_error if method_defined? :display_error
def display_error(*args)
DIV(class: 'hyperstack-top-level-error-boundry') { original_display_error(*args) }
end
end
end
end
```

**Be sure to have the method_defined? guard defined, otherwise you may discover in test or worse in production things won't boot**

Guia de contribuição

Abrir o guia de contribuição

Avaliação

Esta issue ainda não foi avaliada.

Receba novas issues na sua caixa de entrada

Um resumo curto de issues do GitHub para quem está começando.