hyperstack-org / hyperstack-org/hyperstack

The DIV generated by the top level component error handler should have a class

Abierto
#308 0 comentarios 0 reacciones 0 asignados Ver en GitHub
enhancement good first issue
Lenguaje dominante
JavaScript
Estrellas
538
Forks
41
Métricas de merge de PR
Sin PR fusionados en 30 d

Descripción

In order easily style the top level component error handler back stop it should have a class (like ''hyperstack-top-level-error-boundry' that you can set the CSS for.

I.e. make the text smaller, and give it a white background, etc.

Here is a patch:

```ruby
module Hyperstack
class Hotloader
module AddErrorBoundry
# don't attempt the alias unless the method is defined.
# for example if HotLoader is not included in the stack
alias original_display_error display_error if method_defined? :display_error
def display_error(*args)
DIV(class: 'hyperstack-top-level-error-boundry') { original_display_error(*args) }
end
end
end
end
```

**Be sure to have the method_defined? guard defined, otherwise you may discover in test or worse in production things won't boot**

Guía de contribución

Abrir la guía de contribución

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.