hyperlight-dev / hyperlight-dev/hyperlight
Remove misleading boolean return from `InterruptHandle::kill()`
未关闭
lifecycle/confirmed
- 主要语言
- Rust
- 星标
- 4.7k
- 派生
- 208
- 平均合并
- 1 天 7 小时
- 30 天内合并 PR
- 47
描述
InterruptHandle::kill() currently returns true only if it sends a signal to the vCPU. This is misleading because kill() effectively prevents execution even if no signal is sent (e.g., if called before the vCPU starts within MultiUseSandbox::call()).
The return value was originally intended to indicate whether the cancellation was effective (i.e., if it actually interrupted the guest). However, since the return value cannot accurately reflect whether execution was stopped or prevented in all cases, I think it should be removed.
贡献指南
评估
这个 Issue 还没有评估数据。