hyperlight-dev / hyperlight-dev/hyperlight

Remove misleading boolean return from `InterruptHandle::kill()`

Aperta
#1,036 0 commenti 1 reazione 1 assegnatario Assegnata a @Copilot Vedi su GitHub
lifecycle/confirmed
Lingua principale
Rust
Stelle
4.7k
Fork
208
Merge medio
1g 7h
PR unite (30g)
47

Descrizione

InterruptHandle::kill() currently returns true only if it sends a signal to the vCPU. This is misleading because kill() effectively prevents execution even if no signal is sent (e.g., if called before the vCPU starts within MultiUseSandbox::call()).

The return value was originally intended to indicate whether the cancellation was effective (i.e., if it actually interrupted the guest). However, since the return value cannot accurately reflect whether execution was stopped or prevented in all cases, I think it should be removed.

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.