hyperlight-dev / hyperlight-dev/hyperlight
Remove misleading boolean return from `InterruptHandle::kill()`
Abierto
lifecycle/confirmed
- Lenguaje dominante
- Rust
- Estrellas
- 4.7k
- Forks
- 208
- Merge medio
- 1 d 7 h
- PR fusionados (30 d)
- 47
Descripción
InterruptHandle::kill() currently returns true only if it sends a signal to the vCPU. This is misleading because kill() effectively prevents execution even if no signal is sent (e.g., if called before the vCPU starts within MultiUseSandbox::call()).
The return value was originally intended to indicate whether the cancellation was effective (i.e., if it actually interrupted the guest). However, since the return value cannot accurately reflect whether execution was stopped or prevented in all cases, I think it should be removed.
Guía de contribución
Evaluación
Este issue todavía no se ha evaluado.