hardbyte / hardbyte/python-common-expression-language

Expose the parsed expression tree from Program (for explain/trace tooling, linting and sub-expression evaluation)

オープン
#48 コメント 0 件 リアクション 0 件 担当者 0 名 GitHub で見る
enhancement
主要言語
Python
スター
43
フォーク
4
平均マージ
9時間 57分
マージ済み PR(30日)
14

説明

## Motivation

`Program.references()` answers "which names does this expression use", but several things people ask for need the structure of the expression, not just its leaves:

- #30 wants to know *which* element or clause made an `exists`/`&&` chain true or false. cel-rust has no evaluation hooks, so a wrapper-side `explain()` would have to walk the tree and re-evaluate sub-expressions.
- Policy linting beyond name lists: "no `matches()` on untrusted input", "no more than N nested comprehensions", "field access only under `request.`".
- Pretty-printing / normalising expressions stored by users.

## What upstream gives us

`cel::Program::expression()` returns the parsed `Expression` (`IdedExpr`: an id plus an `Expr` enum covering literals, identifiers, selects, calls, lists, maps, structs and the expanded comprehensions). No protobuf AST, but the shape is close to `cel.expr.Expr` and would be straightforward to mirror as nested dicts or small dataclasses.

## Proposal

`Program.ast()` returning a plain, JSON-serialisable tree, e.g. `{"kind": "call", "function": "_&&_", "args": [...]}`, with comprehension macros shown in their expanded form (that is what cel-rust holds after parsing; the original macro call is not retained). Ship it as provisional, tied to the cel-rust version, and note that the node shapes may change when cel-rust changes its AST.

A Python-side `cel.explain(program, context)` built on it could then evaluate each boolean sub-expression and report the first failing clause, which covers the `exists`/`all` case in #30 without upstream changes, at the cost of re-evaluation (custom functions run again).

コントリビューションガイド

コントリビューションガイドを開く

調査の方向性

Start by inspecting the Python Program wrapper and cel::Program::expression(), then compare its IdedExpr and Expr variants with the proposed JSON-serialisable tree. Done means Program.ast() exposes literals, identifiers, selects, calls, lists, maps, structs and expanded comprehensions, with provisional documentation tied to the cel-rust version.

索引モデルが issue の本文から書いたものです。

評価

技術スタック
python, rust
領域
developer-experience, tooling
issue の種類
機能追加
難易度
5/5
見積もり時間
1週間以上
活発さ
活発
明瞭さ
おおむね明確
初心者へのやさしさ
45/100

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。