hardbyte / hardbyte/python-common-expression-language

Expose the parsed expression tree from Program (for explain/trace tooling, linting and sub-expression evaluation)

Ouverte
#48 0 commentaires 0 réactions 0 personnes assignées Voir sur GitHub
enhancement
Langage dominant
Python
Étoiles
43
Forks
4
Merge moyen
9 h 57 min
PR mergées (30 j)
14

Description

## Motivation

`Program.references()` answers "which names does this expression use", but several things people ask for need the structure of the expression, not just its leaves:

- #30 wants to know *which* element or clause made an `exists`/`&&` chain true or false. cel-rust has no evaluation hooks, so a wrapper-side `explain()` would have to walk the tree and re-evaluate sub-expressions.
- Policy linting beyond name lists: "no `matches()` on untrusted input", "no more than N nested comprehensions", "field access only under `request.`".
- Pretty-printing / normalising expressions stored by users.

## What upstream gives us

`cel::Program::expression()` returns the parsed `Expression` (`IdedExpr`: an id plus an `Expr` enum covering literals, identifiers, selects, calls, lists, maps, structs and the expanded comprehensions). No protobuf AST, but the shape is close to `cel.expr.Expr` and would be straightforward to mirror as nested dicts or small dataclasses.

## Proposal

`Program.ast()` returning a plain, JSON-serialisable tree, e.g. `{"kind": "call", "function": "_&&_", "args": [...]}`, with comprehension macros shown in their expanded form (that is what cel-rust holds after parsing; the original macro call is not retained). Ship it as provisional, tied to the cel-rust version, and note that the node shapes may change when cel-rust changes its AST.

A Python-side `cel.explain(program, context)` built on it could then evaluate each boolean sub-expression and report the first failing clause, which covers the `exists`/`all` case in #30 without upstream changes, at the cost of re-evaluation (custom functions run again).

Guide de contribution

Ouvrir le guide de contribution

Piste de recherche

Start by inspecting the Python Program wrapper and cel::Program::expression(), then compare its IdedExpr and Expr variants with the proposed JSON-serialisable tree. Done means Program.ast() exposes literals, identifiers, selects, calls, lists, maps, structs and expanded comprehensions, with provisional documentation tied to the cel-rust version.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Évaluation

Stack technique
python, rust
Domaine
developer-experience, tooling
Type d'issue
Fonctionnalité
Difficulté
5/5
Temps estimé
Plus d'une semaine
Activité
Active
Clarté
Plutôt claire
Accessibilité débutants
45/100

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.