hardbyte / hardbyte/python-can
`send_periodic` does not accept `on_error` callback, resulting in race condition
- Ngôn ngữ chính
- Python
- Star
- 1.6k
- Fork
- 697
- Chỉ số merge pull request
- Không có pull request nào được merge trong 30 ngày
Mô tả
### Describe the bug
When setting up a periodic send task there is no way to configure the `on_error` callback in the task. Therefore, if the very first send attempt in the task fails, the task is aborted. This can happen before the user is able to add a callback to the newly created task. Thus there is a race condition between creating the task and sending the first message, and adding the callback.
### To Reproduce
Open a bus and create a periodic task. If sending to the bus fails, the task is aborted due to no callback being configured.
### Expected behavior
An argument is added to `send_periodic` such that the callback can be set in the constructor of the task.
Hướng dẫn đóng góp
Đánh giá
Issue này chưa được đánh giá.