hardbyte / hardbyte/python-can

`send_periodic` does not accept `on_error` callback, resulting in race condition

未关闭
#1,282 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
bug
主要语言
Python
星标
1.6k
派生
697
PR 合并指标
30 天内没有已合并 PR

描述

### Describe the bug
When setting up a periodic send task there is no way to configure the `on_error` callback in the task. Therefore, if the very first send attempt in the task fails, the task is aborted. This can happen before the user is able to add a callback to the newly created task. Thus there is a race condition between creating the task and sending the first message, and adding the callback.

### To Reproduce
Open a bus and create a periodic task. If sending to the bus fails, the task is aborted due to no callback being configured.

### Expected behavior
An argument is added to `send_periodic` such that the callback can be set in the constructor of the task.

贡献指南

打开贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。