handzlikchris / handzlikchris/FastScriptReload

[Optimization] Some other "Microsoft.CSharp.dll" found in project

Open
#191 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
C#
Stars
2.2k
Forks
167
PR merge metrics
No merged PRs in 30d

Description

Hi!

I’ve been using FSR for a while and find it quite fabulous.

Meanwhile, I’m using some Unity MCP packages that include a customized Microsoft.CSharp.dll. The relevant code in FSR is here:
https://github.com/handzlikchris/FastScriptReload/blob/2018c7615df46777b03b9a87304b65d14e9d0823/Assets/Scripts/Editor/Compilation/DynamicCompilationBase.cs#L64C1-L69C12

Because the dll is customized and its version doesn’t match the standard one, I encounter “dll version not match” failures during patch compiling.

It would be very helpful if FSR could support a special mark for such custom Microsoft.CSharp.dll assemblies—so that they are recognised and handled appropriately.

Thank you very much for considering this!

Contributor guide

No contributing guide indexed for this repository

Research direction

Start in Assets/Scripts/Editor/Compilation/DynamicCompilationBase.cs at the referenced lines and inspect how Microsoft.CSharp.dll assemblies are identified during patch compilation. Reproduce the failure with a customized DLL from a Unity MCP package. Done means custom Microsoft.CSharp.dll assemblies can be marked, recognized, and handled without a version-mismatch failure.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp, unity
Domain
devtools, game-dev
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.