handzlikchris / handzlikchris/FastScriptReload

Interface implementation returning inner class isn't correctly patched

Open
#162 3 comments 0 reactions 0 assignees View on GitHub
Dominant language
C#
Stars
2.2k
Forks
167
PR merge metrics
No merged PRs in 30d

Description

Interface and class in the same file. Method returns inner class.
```csharp
public interface ITest {
Test.Builder Create(Entity entity, string prefixId);
}

public class Test : ITest {
Builder ITest.Create(Entity entity, string prefixId) {
// ...
return new Builder();
}

public class Builder { }
}
```
FSR produces:
```csharp
public interface ITest__Patched_{
Test.Builder Create(Entity entity, string prefixId);
}

public class Test__Patched_: ITest { // error CS0535
Builder ITest.Create(Entity entity, string prefixId) { // error CS0539
// ...
return new Builder();
}

public class Builder { }
}
```
error CS0535: 'Test__Patched_' does not implement interface member 'ITest.Create(Entity, string)'
error CS0539: 'Test__Patched_.Create(Entity, string)' in explicit interface declaration is not found among members of the interface that can be implemented

Moving interface out of the file doesn't help. Same CS0539 and CS0535 errors.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by reproducing the shown C# example with an interface and an inner class whose method returns that inner class. Trace the patching of the interface and implementing class, then verify that the generated code compiles without CS0535 or CS0539, both when the interface is in the same file and when it is moved.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp
Domain
devtools, game-dev
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.