grpc / grpc/grpc-java

Context handling in Tracers

Aperta
#4,815 3 commenti 0 reazioni 1 assegnatario Rivendicata da @zhangkun83 Vedi su GitHub
Lingua principale
Java
Stelle
12.1k
Fork
4k
Merge medio
2g 17h
PR unite (30g)
37

Descrizione

In 1.10 and 1.11 the `Context` returned by `ServerStreamTracer.filterContext` was attached when `streamClosed` was invoked. As of 1.12 (and continuing through 1.14) this no longer seems to be the case. It appears this was undocumented behavior and relying on it was my mistake.

That said, I think it _would_ be nice if `ServerStreamTracer` methods were guaranteed to be invoked with the filtered `Context` attached. Either way, it would be helpful to have the Javadoc for `filterContext` specify whether or not the filtered `Context` is attached when other `ServerStreamTracer` methods are invoked.

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.