Context handling in Tracers
Abierto
@zhangkun83 ya está trabajando en esto.
Desde el 4/9/2018.
- Lenguaje dominante
- Java
- Estrellas
- 12.1k
- Forks
- 4k
- Merge medio
- 2 d 17 h
- PR fusionados (30 d)
- 37
Descripción
In 1.10 and 1.11 the Context returned by ServerStreamTracer.filterContext was attached when streamClosed was invoked. As of 1.12 (and continuing through 1.14) this no longer seems to be the case. It appears this was undocumented behavior and relying on it was my mistake.
That said, I think it would be nice if ServerStreamTracer methods were guaranteed to be invoked with the filtered Context attached. Either way, it would be helpful to have the Javadoc for filterContext specify whether or not the filtered Context is attached when other ServerStreamTracer methods are invoked.
Guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Evaluación
Este issue todavía no se ha evaluado.