Context handling in Tracers
Offen
#4,815
3 Kommentare
0 Reaktionen
1 zugewiesene Person
Beansprucht von @zhangkun83
Auf GitHub ansehen
- Vorherrschende Sprache
- Java
- Sterne
- 12.1k
- Forks
- 4k
- Ø Merge
- 2 T. 17 Std.
- Gemergte PRs (30 T.)
- 37
Beschreibung
In 1.10 and 1.11 the `Context` returned by `ServerStreamTracer.filterContext` was attached when `streamClosed` was invoked. As of 1.12 (and continuing through 1.14) this no longer seems to be the case. It appears this was undocumented behavior and relying on it was my mistake.
That said, I think it _would_ be nice if `ServerStreamTracer` methods were guaranteed to be invoked with the filtered `Context` attached. Either way, it would be helpful to have the Javadoc for `filterContext` specify whether or not the filtered `Context` is attached when other `ServerStreamTracer` methods are invoked.
Beitragsleitfaden
Bewertung
Dieses Issue wurde noch nicht bewertet.