grpc / grpc/grpc-java

Test historic generated code

Aperta
#2,783 0 commenti 0 reazioni 1 assegnatario Rivendicata da @ejona86 Vedi su GitHub
code health
Lingua principale
Java
Stelle
12.1k
Fork
4k
Merge medio
2g 17h
PR unite (30g)
37

Descrizione

We should check in generated code for each minor version of grpc, and at least makes sure it compiles. If it compiles, it is highly likely to work.

Ideally we'd run some simple sanity tests, although it is hard to force all the code to run. Maybe we create a noop-ImplBase service and call bindService(). That would at least load all the MethodDescriptors... I don't think a literal test is necessary before closing this. The compilation itself can count as a "test." But it should at least be briefly investigated before closing.

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.