grpc / grpc/grpc-java

Test historic generated code

Offen
#2,783 0 Kommentare 0 Reaktionen 1 zugewiesene Person Beansprucht von @ejona86 Auf GitHub ansehen
code health
Vorherrschende Sprache
Java
Sterne
12.1k
Forks
4k
Ø Merge
2 T. 17 Std.
Gemergte PRs (30 T.)
37

Beschreibung

We should check in generated code for each minor version of grpc, and at least makes sure it compiles. If it compiles, it is highly likely to work.

Ideally we'd run some simple sanity tests, although it is hard to force all the code to run. Maybe we create a noop-ImplBase service and call bindService(). That would at least load all the MethodDescriptors... I don't think a literal test is necessary before closing this. The compilation itself can count as a "test." But it should at least be briefly investigated before closing.

Beitragsleitfaden

Beitragsleitfaden öffnen

Bewertung

Dieses Issue wurde noch nicht bewertet.

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.