grpc / grpc/grpc-java

Test historic generated code

Abierto
#2,783 0 comentarios 0 reacciones 1 asignado Reclamado por @ejona86 Ver en GitHub
code health
Lenguaje dominante
Java
Estrellas
12.1k
Forks
4k
Merge medio
2 d 17 h
PR fusionados (30 d)
37

Descripción

We should check in generated code for each minor version of grpc, and at least makes sure it compiles. If it compiles, it is highly likely to work.

Ideally we'd run some simple sanity tests, although it is hard to force all the code to run. Maybe we create a noop-ImplBase service and call bindService(). That would at least load all the MethodDescriptors... I don't think a literal test is necessary before closing this. The compilation itself can count as a "test." But it should at least be briefly investigated before closing.

Guía de contribución

Abrir la guía de contribución

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.