grpc / grpc/grpc-java

Test historic generated code

Open
#2,783 0 comments 0 reactions 1 assignee Claimed by @ejona86 View on GitHub
code health
Dominant language
Java
Stars
12.1k
Forks
4k
Avg merge
2d 17h
Merged PRs (30d)
37

Description

We should check in generated code for each minor version of grpc, and at least makes sure it compiles. If it compiles, it is highly likely to work.

Ideally we'd run some simple sanity tests, although it is hard to force all the code to run. Maybe we create a noop-ImplBase service and call bindService(). That would at least load all the MethodDescriptors... I don't think a literal test is necessary before closing this. The compilation itself can count as a "test." But it should at least be briefly investigated before closing.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.