grafana / grafana/pyroscope-python

Missing log_level option for Python client

未关闭
#44 1 条评论 1 个 reaction 已指派 0 人 在 GitHub 查看
bug
主要语言
Rust
星标
4
派生
2
平均合并
2 天 4 小时
30 天内合并 PR
5

描述

First of all, thanks for creating an awesome profiling tool. 👏🏾

**Describe the bug you encountered:**
The doc mentioned that we could configure the `log_level`.

```python
import pyroscope

pyroscope.configure(
....
log_level = "info" # default is info, possible values: trace, debug, info, warn, error, and critical
)
```
When I configured the log_level, I got the error
```
pyroscope.configure(
TypeError: configure() got an unexpected keyword argument 'log_level'
```

**What did you expect to happen instead?**
I expect the `log_level` parameter to exist and should only see certain logs.

**How did you install `pyroscope-rs`?**
I installed it with `pip install pyroscope-io -U`

---

**pyroscope-rs version and environment**
```
$ pip list | grep pyro
pyroscope-io 0.7.2
$ python3 --version
Python 3.10.1
```

I took a peak at the code and found that the `log_level` param is missing from the `configure` function
https://github.com/pyroscope-io/pyroscope-rs/blob/main/pyroscope_ffi/python/pyroscope/__init__.py#L12-L15
Digging a bit deeper, the param `log_level` was removed in this commit https://github.com/pyroscope-io/pyroscope-rs/commit/1696cd06db53a1d7ebbdcee556334156eed3429e.

贡献指南

这个仓库没有索引到贡献指南

调研方向

Start in pyroscope_ffi/python/pyroscope/__init__.py at the configure function, then compare its current arguments with the linked commit that removed log_level. Verify the Python 0.7.2 behavior and logging configuration path; done means configure accepts log_level and applies the documented log filtering values.

由索引模型根据 Issue 内容生成。

评估

技术栈
python, rust
领域
developer-experience
Issue 类型
缺陷
难度
2/5
预计耗时
1-3 小时
活跃度
停滞
描述清晰度
描述清楚
新手友好度
35/100

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。