grafana / grafana/pyroscope-python

Missing log_level option for Python client

Aperta
#44 1 commento 1 reazione 0 assegnatari Vedi su GitHub
bug
Lingua principale
Rust
Stelle
4
Fork
2
Merge medio
2g 4h
PR unite (30g)
5

Descrizione

First of all, thanks for creating an awesome profiling tool. 👏🏾

**Describe the bug you encountered:**
The doc mentioned that we could configure the `log_level`.

```python
import pyroscope

pyroscope.configure(
....
log_level = "info" # default is info, possible values: trace, debug, info, warn, error, and critical
)
```
When I configured the log_level, I got the error
```
pyroscope.configure(
TypeError: configure() got an unexpected keyword argument 'log_level'
```

**What did you expect to happen instead?**
I expect the `log_level` parameter to exist and should only see certain logs.

**How did you install `pyroscope-rs`?**
I installed it with `pip install pyroscope-io -U`

---

**pyroscope-rs version and environment**
```
$ pip list | grep pyro
pyroscope-io 0.7.2
$ python3 --version
Python 3.10.1
```

I took a peak at the code and found that the `log_level` param is missing from the `configure` function
https://github.com/pyroscope-io/pyroscope-rs/blob/main/pyroscope_ffi/python/pyroscope/__init__.py#L12-L15
Digging a bit deeper, the param `log_level` was removed in this commit https://github.com/pyroscope-io/pyroscope-rs/commit/1696cd06db53a1d7ebbdcee556334156eed3429e.

Guida per i contributori

Nessuna guida per i contributori indicizzata per questo repository

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.