grafana / grafana/pyroscope-python

Missing log_level option for Python client

Abierto
#44 1 comentario 1 reacción 0 asignados Ver en GitHub
bug
Lenguaje dominante
Rust
Estrellas
4
Forks
2
Merge medio
2 d 4 h
PR fusionados (30 d)
5

Descripción

First of all, thanks for creating an awesome profiling tool. 👏🏾

**Describe the bug you encountered:**
The doc mentioned that we could configure the `log_level`.

```python
import pyroscope

pyroscope.configure(
....
log_level = "info" # default is info, possible values: trace, debug, info, warn, error, and critical
)
```
When I configured the log_level, I got the error
```
pyroscope.configure(
TypeError: configure() got an unexpected keyword argument 'log_level'
```

**What did you expect to happen instead?**
I expect the `log_level` parameter to exist and should only see certain logs.

**How did you install `pyroscope-rs`?**
I installed it with `pip install pyroscope-io -U`

---

**pyroscope-rs version and environment**
```
$ pip list | grep pyro
pyroscope-io 0.7.2
$ python3 --version
Python 3.10.1
```

I took a peak at the code and found that the `log_level` param is missing from the `configure` function
https://github.com/pyroscope-io/pyroscope-rs/blob/main/pyroscope_ffi/python/pyroscope/__init__.py#L12-L15
Digging a bit deeper, the param `log_level` was removed in this commit https://github.com/pyroscope-io/pyroscope-rs/commit/1696cd06db53a1d7ebbdcee556334156eed3429e.

Guía de contribución

No hay ninguna guía de contribución indexada para este repositorio

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.