googlemaps / googlemaps/google-maps-services-python

Client: client does not close SSL socket after request completes

Aberta
#386 1 comentário 0 reações 0 responsáveis Ver no GitHub
priority: p3 type: bug
Linguagem predominante
Python
Estrelas
5k
Forks
1.4k
Métricas de merge de PRs
Nenhum PR com merge em 30d

Descrição

#### Environment details

1. Occurs with any request using googlemaps.Client
2. macOS Mojave
3. Library version: 4.4.2

#### Steps to reproduce

1. Instantiate a googlemaps Client
2. Make a request
3. Observe warning of unclosed SSL socket in console

#### Code example

```python
import googlemaps

def get_lat_lng(self, address: str):
gmaps = googlemaps.Client(key="api_key")
geocode_result = gmaps.geocode(address)
return geocode_result

```

#### Stack trace
```
ResourceWarning: unclosed
```

### Impact:
Services using the googlemaps client could easily run out of sockets because of this bug.

### Potential resolution:
This bug appears to be the same as https://github.com/googleapis/google-api-python-client/issues/618
If it is indeed the same there was a fix in google-api-python-client here: https://github.com/googleapis/google-api-python-client/pull/1038

Guia de contribuição

Abrir o guia de contribuição

Avaliação

Esta issue ainda não foi avaliada.

Receba novas issues na sua caixa de entrada

Um resumo curto de issues do GitHub para quem está começando.