googlemaps / googlemaps/google-maps-services-python

Client: client does not close SSL socket after request completes

Aperta
#386 1 commento 0 reazioni 0 assegnatari Vedi su GitHub
priority: p3 type: bug
Lingua principale
Python
Stelle
5k
Fork
1.4k
Metriche di merge delle PR
Nessuna PR unita negli ultimi 30g

Descrizione

#### Environment details

1. Occurs with any request using googlemaps.Client
2. macOS Mojave
3. Library version: 4.4.2

#### Steps to reproduce

1. Instantiate a googlemaps Client
2. Make a request
3. Observe warning of unclosed SSL socket in console

#### Code example

```python
import googlemaps

def get_lat_lng(self, address: str):
gmaps = googlemaps.Client(key="api_key")
geocode_result = gmaps.geocode(address)
return geocode_result

```

#### Stack trace
```
ResourceWarning: unclosed
```

### Impact:
Services using the googlemaps client could easily run out of sockets because of this bug.

### Potential resolution:
This bug appears to be the same as https://github.com/googleapis/google-api-python-client/issues/618
If it is indeed the same there was a fix in google-api-python-client here: https://github.com/googleapis/google-api-python-client/pull/1038

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.