googlemaps / googlemaps/google-maps-services-python

Client: client does not close SSL socket after request completes

Abierto
#386 1 comentario 0 reacciones 0 asignados Ver en GitHub
priority: p3 type: bug
Lenguaje dominante
Python
Estrellas
5k
Forks
1.4k
Métricas de merge de PR
Sin PR fusionados en 30 d

Descripción

#### Environment details

1. Occurs with any request using googlemaps.Client
2. macOS Mojave
3. Library version: 4.4.2

#### Steps to reproduce

1. Instantiate a googlemaps Client
2. Make a request
3. Observe warning of unclosed SSL socket in console

#### Code example

```python
import googlemaps

def get_lat_lng(self, address: str):
gmaps = googlemaps.Client(key="api_key")
geocode_result = gmaps.geocode(address)
return geocode_result

```

#### Stack trace
```
ResourceWarning: unclosed
```

### Impact:
Services using the googlemaps client could easily run out of sockets because of this bug.

### Potential resolution:
This bug appears to be the same as https://github.com/googleapis/google-api-python-client/issues/618
If it is indeed the same there was a fix in google-api-python-client here: https://github.com/googleapis/google-api-python-client/pull/1038

Guía de contribución

Abrir la guía de contribución

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.