googleapis / googleapis/google-http-java-client

HttpResponse should implement Closeable

オープン
#740 コメント 1 件 リアクション 2 件 担当者 0 名 GitHub で見る
type: feature request
主要言語
Java
スター
1.4k
フォーク
473
PR マージ指標
30日以内にマージされた PR はありません

説明

Currently a `HttpResponse` needs to be disconnected to release resources and avoid leaks. This is fine but it can lead to easy mistakes as people new to the library don't realise this or forget.

If `HttpResponse` implemented the `java.io.Closeable` interface then I think there would be a number of benefits:
- Can use try-with-resources. :+1: :+1: :+1:
- More familiar to developers by implementing the standard interface and using standard method names.
- IDEs and static analysis tools may pick up resource leaks automatically without any extra configuration.

The main downside I can see is that we'd have to keep the `disconnect` method for backwards compatibility and this would mean there would be two interfaces for the same action. Is this a problem? I leave that decision up to you.

I would be happy to implement this if that would help things. It shouldn't be very much work at all. I'm opening this feature request issue in order to gauge if it would be a good idea to implement this or not.

コントリビューションガイド

コントリビューションガイドを開く

評価

この issue はまだ評価されていません。

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。