googleapis / googleapis/google-http-java-client

HttpResponse should implement Closeable

Abierto
#740 1 comentario 2 reacciones 0 asignados Ver en GitHub
type: feature request
Lenguaje dominante
Java
Estrellas
1.4k
Forks
473
Métricas de merge de PR
Sin PR fusionados en 30 d

Descripción

Currently a `HttpResponse` needs to be disconnected to release resources and avoid leaks. This is fine but it can lead to easy mistakes as people new to the library don't realise this or forget.

If `HttpResponse` implemented the `java.io.Closeable` interface then I think there would be a number of benefits:
- Can use try-with-resources. :+1: :+1: :+1:
- More familiar to developers by implementing the standard interface and using standard method names.
- IDEs and static analysis tools may pick up resource leaks automatically without any extra configuration.

The main downside I can see is that we'd have to keep the `disconnect` method for backwards compatibility and this would mean there would be two interfaces for the same action. Is this a problem? I leave that decision up to you.

I would be happy to implement this if that would help things. It shouldn't be very much work at all. I'm opening this feature request issue in order to gauge if it would be a good idea to implement this or not.

Guía de contribución

Abrir la guía de contribución

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.