googleapis / googleapis/google-cloud-python

ensure we have test coverage for gRPC bidi streaming

未关闭
#16,288 1 条评论 0 个 reaction 已指派 1 人 已被 @ohmayr 认领 在 GitHub 查看
priority: p2 type: process
主要语言
Python
星标
5.4k
派生
1.8k
平均合并
3 天 4 小时
30 天内合并 PR
122

描述

[This comment thread](https://github.com/googleapis/gapic-generator-python/commit/c4408075f8cc8a270af4a818ea7aafc0c2ad6a7e#r146008230) highlights that some unknown time ago, code that was apparently meant to cover several cases including bi-directional streaming was moved into sections of macro files that were only generated `{% if not method.client_streaming %}`. This raises the possibility that the corresponding bidi code might have had its test coverage accidentally removed. We should check whether that is indeed the case (I suggest starting with git blame to see when the code made it into `test_macros.j2` from where), and if so, fix it.

贡献指南

打开贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。