googleapis / googleapis/google-cloud-python

ensure we have test coverage for gRPC bidi streaming

Offen
#16,288 1 Kommentar 0 Reaktionen 1 zugewiesene Person Beansprucht von @ohmayr Auf GitHub ansehen
priority: p2 type: process
Vorherrschende Sprache
Python
Sterne
5.4k
Forks
1.8k
Ø Merge
3 T. 4 Std.
Gemergte PRs (30 T.)
122

Beschreibung

[This comment thread](https://github.com/googleapis/gapic-generator-python/commit/c4408075f8cc8a270af4a818ea7aafc0c2ad6a7e#r146008230) highlights that some unknown time ago, code that was apparently meant to cover several cases including bi-directional streaming was moved into sections of macro files that were only generated `{% if not method.client_streaming %}`. This raises the possibility that the corresponding bidi code might have had its test coverage accidentally removed. We should check whether that is indeed the case (I suggest starting with git blame to see when the code made it into `test_macros.j2` from where), and if so, fix it.

Beitragsleitfaden

Beitragsleitfaden öffnen

Bewertung

Dieses Issue wurde noch nicht bewertet.

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.