googleapis / googleapis/google-cloud-python

ensure we have test coverage for gRPC bidi streaming

Aperta
#16,288 1 commento 0 reazioni 1 assegnatario Rivendicata da @ohmayr Vedi su GitHub
priority: p2 type: process
Lingua principale
Python
Stelle
5.4k
Fork
1.8k
Merge medio
3g 4h
PR unite (30g)
122

Descrizione

[This comment thread](https://github.com/googleapis/gapic-generator-python/commit/c4408075f8cc8a270af4a818ea7aafc0c2ad6a7e#r146008230) highlights that some unknown time ago, code that was apparently meant to cover several cases including bi-directional streaming was moved into sections of macro files that were only generated `{% if not method.client_streaming %}`. This raises the possibility that the corresponding bidi code might have had its test coverage accidentally removed. We should check whether that is indeed the case (I suggest starting with git blame to see when the code made it into `test_macros.j2` from where), and if so, fix it.

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.