googleapis / googleapis/google-cloud-python

[async rest] Add support for async request / response interceptors for unsupported methods

Aberta
#16,280 1 comentário 0 reações 1 responsável Reivindicada por @ohmayr Ver no GitHub
priority: p2 type: feature request
Linguagem predominante
Python
Estrelas
5.4k
Forks
1.8k
Merge médio
2d 23h
PRs com merge (30d)
123

Descrição

The macro `shared_macros.create_interceptor_class` which generates an interceptor class for async / sync rest transport currently guards generation of asynchronous interceptor class methods for the following type of api methods:

- `lro`
- `extended_lro`
- `paged_result_field`

As we add support for the api methods mentioned above in the asynchronous rest transport class, we need to ensure that support is also added for interceptor class methods for the corresponding api methods. This can be achieved by updating and eventually removing the following condition within the macro:

```
% if (not is_async) or (is_async and not method.lro and not method.extended_lro and not method.paged_result_field) %}
```

The above condition / code change location can be looked up by searching for this issue url / number.

Guia de contribuição

Abrir o guia de contribuição

Avaliação

Esta issue ainda não foi avaliada.

Receba novas issues na sua caixa de entrada

Um resumo curto de issues do GitHub para quem está começando.