googleapis / googleapis/google-cloud-python

[async rest] Add support for async request / response interceptors for unsupported methods

Offen
#16,280 1 Kommentar 0 Reaktionen 1 zugewiesene Person Beansprucht von @ohmayr Auf GitHub ansehen
priority: p2 type: feature request
Vorherrschende Sprache
Python
Sterne
5.4k
Forks
1.8k
Ø Merge
3 T. 4 Std.
Gemergte PRs (30 T.)
122

Beschreibung

The macro `shared_macros.create_interceptor_class` which generates an interceptor class for async / sync rest transport currently guards generation of asynchronous interceptor class methods for the following type of api methods:

- `lro`
- `extended_lro`
- `paged_result_field`

As we add support for the api methods mentioned above in the asynchronous rest transport class, we need to ensure that support is also added for interceptor class methods for the corresponding api methods. This can be achieved by updating and eventually removing the following condition within the macro:

```
% if (not is_async) or (is_async and not method.lro and not method.extended_lro and not method.paged_result_field) %}
```

The above condition / code change location can be looked up by searching for this issue url / number.

Beitragsleitfaden

Beitragsleitfaden öffnen

Bewertung

Dieses Issue wurde noch nicht bewertet.

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.