googleapis / googleapis/google-cloud-python

[async rest] Add support for async request / response interceptors for unsupported methods

Ouverte
#16,280 1 commentaire 0 réactions 1 personne assignée Réclamée par @ohmayr Voir sur GitHub
priority: p2 type: feature request
Langage dominant
Python
Étoiles
5.4k
Forks
1.8k
Merge moyen
3 j 4 h
PR mergées (30 j)
122

Description

The macro `shared_macros.create_interceptor_class` which generates an interceptor class for async / sync rest transport currently guards generation of asynchronous interceptor class methods for the following type of api methods:

- `lro`
- `extended_lro`
- `paged_result_field`

As we add support for the api methods mentioned above in the asynchronous rest transport class, we need to ensure that support is also added for interceptor class methods for the corresponding api methods. This can be achieved by updating and eventually removing the following condition within the macro:

```
% if (not is_async) or (is_async and not method.lro and not method.extended_lro and not method.paged_result_field) %}
```

The above condition / code change location can be looked up by searching for this issue url / number.

Guide de contribution

Ouvrir le guide de contribution

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.