googleapis / googleapis/google-cloud-python

Add tests for generated samples

未关闭
#15,411 1 条评论 0 个 reaction 已指派 1 人 已被 @gkevinzheng 认领 在 GitHub 查看
api: logging priority: p3 samples type: cleanup
主要语言
Python
星标
5.4k
派生
1.8k
平均合并
2 天 23 小时
30 天内合并 PR
123

描述

One thought: these generated samples aren't covered by tests. Have you considered adding tests for these to catch this kind of issue in the future, like the [other snippets](https://github.com/googleapis/python-logging/tree/c201482c913b5f2eac82359787511a5a92fc3406/samples/snippets)? Smoke tests could be helpful here (i.e. just executing each function and making sure nothing crashes)

There may be a simple way to programmatically load and execute each sample, but if it's bit more complicated we could open a bug for later

_Originally posted by @daniel-sanche in https://github.com/googleapis/python-logging/pull/804#discussion_r1377993742_

贡献指南

打开贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。