googleapis / googleapis/google-cloud-python

Add tests for generated samples

Aperta
#15,411 1 commento 0 reazioni 1 assegnatario Rivendicata da @gkevinzheng Vedi su GitHub
api: logging priority: p3 samples type: cleanup
Lingua principale
Python
Stelle
5.4k
Fork
1.8k
Merge medio
3g 4h
PR unite (30g)
122

Descrizione

One thought: these generated samples aren't covered by tests. Have you considered adding tests for these to catch this kind of issue in the future, like the [other snippets](https://github.com/googleapis/python-logging/tree/c201482c913b5f2eac82359787511a5a92fc3406/samples/snippets)? Smoke tests could be helpful here (i.e. just executing each function and making sure nothing crashes)

There may be a simple way to programmatically load and execute each sample, but if it's bit more complicated we could open a bug for later

_Originally posted by @daniel-sanche in https://github.com/googleapis/python-logging/pull/804#discussion_r1377993742_

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.