googleapis / googleapis/google-cloud-python

Add tests for generated samples

Offen
#15,411 1 Kommentar 0 Reaktionen 1 zugewiesene Person Beansprucht von @gkevinzheng Auf GitHub ansehen
api: logging priority: p3 samples type: cleanup
Vorherrschende Sprache
Python
Sterne
5.4k
Forks
1.8k
Ø Merge
2 T. 23 Std.
Gemergte PRs (30 T.)
123

Beschreibung

One thought: these generated samples aren't covered by tests. Have you considered adding tests for these to catch this kind of issue in the future, like the [other snippets](https://github.com/googleapis/python-logging/tree/c201482c913b5f2eac82359787511a5a92fc3406/samples/snippets)? Smoke tests could be helpful here (i.e. just executing each function and making sure nothing crashes)

There may be a simple way to programmatically load and execute each sample, but if it's bit more complicated we could open a bug for later

_Originally posted by @daniel-sanche in https://github.com/googleapis/python-logging/pull/804#discussion_r1377993742_

Beitragsleitfaden

Beitragsleitfaden öffnen

Bewertung

Dieses Issue wurde noch nicht bewertet.

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.