googleapis / googleapis/google-cloud-python

Add tests for generated samples

Open
#15,411 1 comment 0 reactions 1 assignee Claimed by @gkevinzheng View on GitHub
api: logging priority: p3 samples type: cleanup
Dominant language
Python
Stars
5.4k
Forks
1.8k
Avg merge
3d 4h
Merged PRs (30d)
122

Description

One thought: these generated samples aren't covered by tests. Have you considered adding tests for these to catch this kind of issue in the future, like the [other snippets](https://github.com/googleapis/python-logging/tree/c201482c913b5f2eac82359787511a5a92fc3406/samples/snippets)? Smoke tests could be helpful here (i.e. just executing each function and making sure nothing crashes)

There may be a simple way to programmatically load and execute each sample, but if it's bit more complicated we could open a bug for later

_Originally posted by @daniel-sanche in https://github.com/googleapis/python-logging/pull/804#discussion_r1377993742_

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.