googleapis / googleapis/google-cloud-python
Replace transaction retries with api_core implementation
未关闭
api: firestore
priority: p3
type: feature request
- 主要语言
- Python
- 星标
- 5.4k
- 派生
- 1.8k
- 平均合并
- 3 天 4 小时
- 30 天内合并 PR
- 122
描述
Transaction-level retries currently use a hand-rolled implementation within [Transactional.__call__](https://github.com/googleapis/python-firestore/blob/8ddb859c8178043c0dcd09c85d68ba5d311563bf/google/cloud/firestore_v1/transaction.py#L244), AsyncTransactional.__call__, and [_commit_with_retry](https://github.com/googleapis/python-firestore/blob/8ddb859c8178043c0dcd09c85d68ba5d311563bf/google/cloud/firestore_v1/transaction.py#L309)
We should replace these with the standard api_core.Retry gunctionality, to remove duplicated code
贡献指南
评估
这个 Issue 还没有评估数据。