googleapis / googleapis/google-cloud-python
Replace transaction retries with api_core implementation
Open
api: firestore
priority: p3
type: feature request
- Dominant language
- Python
- Stars
- 5.4k
- Forks
- 1.8k
- Avg merge
- 3d 4h
- Merged PRs (30d)
- 122
Description
Transaction-level retries currently use a hand-rolled implementation within [Transactional.__call__](https://github.com/googleapis/python-firestore/blob/8ddb859c8178043c0dcd09c85d68ba5d311563bf/google/cloud/firestore_v1/transaction.py#L244), AsyncTransactional.__call__, and [_commit_with_retry](https://github.com/googleapis/python-firestore/blob/8ddb859c8178043c0dcd09c85d68ba5d311563bf/google/cloud/firestore_v1/transaction.py#L309)
We should replace these with the standard api_core.Retry gunctionality, to remove duplicated code
Contributor guide
Assessment
This issue has not been assessed yet.