googleapis / googleapis/google-cloud-python
Replace transaction retries with api_core implementation
Abierto
api: firestore
priority: p3
type: feature request
- Lenguaje dominante
- Python
- Estrellas
- 5.4k
- Forks
- 1.8k
- Merge medio
- 3 d 4 h
- PR fusionados (30 d)
- 122
Descripción
Transaction-level retries currently use a hand-rolled implementation within [Transactional.__call__](https://github.com/googleapis/python-firestore/blob/8ddb859c8178043c0dcd09c85d68ba5d311563bf/google/cloud/firestore_v1/transaction.py#L244), AsyncTransactional.__call__, and [_commit_with_retry](https://github.com/googleapis/python-firestore/blob/8ddb859c8178043c0dcd09c85d68ba5d311563bf/google/cloud/firestore_v1/transaction.py#L309)
We should replace these with the standard api_core.Retry gunctionality, to remove duplicated code
Guía de contribución
Evaluación
Este issue todavía no se ha evaluado.