googleapis / googleapis/google-cloud-java

[google-auth-library-java] evaluate refactor builder patterns so that setters do not need to be override in child classes.

Aperta
#12,590 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub
priority: p3 type: cleanup
Lingua principale
Java
Stelle
2.1k
Fork
1.2k
Merge medio
1g 23h
PR unite (30g)
154

Descrizione

see this comment for context: https://github.com/googleapis/google-auth-library-java/pull/1528#discussion_r1801591146

builders are not created with generic types across this repo e.g. https://github.com/googleapis/google-auth-library-java/blob/f154edb3d8503d29f0020b6904dfa40e034ded93/oauth2_http/java/com/google/auth/oauth2/GoogleCredentials.java#L486

This means to allow customer code to use a fluent builder API without casting, setters in parent classes need to be overriden in child classes, even without adding specific logics.

Note that adding generics to existing classes may also produce warning regarding raw use of generic types.

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.