googleapis / googleapis/google-cloud-java
[google-auth-library-java] evaluate refactor builder patterns so that setters do not need to be override in child classes.
- Lenguaje dominante
- Java
- Estrellas
- 2.1k
- Forks
- 1.2k
- Merge medio
- 1 d 23 h
- PR fusionados (30 d)
- 154
Descripción
see this comment for context: https://github.com/googleapis/google-auth-library-java/pull/1528#discussion_r1801591146
builders are not created with generic types across this repo e.g. https://github.com/googleapis/google-auth-library-java/blob/f154edb3d8503d29f0020b6904dfa40e034ded93/oauth2_http/java/com/google/auth/oauth2/GoogleCredentials.java#L486
This means to allow customer code to use a fluent builder API without casting, setters in parent classes need to be overriden in child classes, even without adding specific logics.
Note that adding generics to existing classes may also produce warning regarding raw use of generic types.
Guía de contribución
Evaluación
Este issue todavía no se ha evaluado.