googleapis / googleapis/google-cloud-java
[google-auth-library-java] evaluate refactor builder patterns so that setters do not need to be override in child classes.
- Langage dominant
- Java
- Étoiles
- 2.1k
- Forks
- 1.2k
- Merge moyen
- 1 j 23 h
- PR mergées (30 j)
- 154
Description
see this comment for context: https://github.com/googleapis/google-auth-library-java/pull/1528#discussion_r1801591146
builders are not created with generic types across this repo e.g. https://github.com/googleapis/google-auth-library-java/blob/f154edb3d8503d29f0020b6904dfa40e034ded93/oauth2_http/java/com/google/auth/oauth2/GoogleCredentials.java#L486
This means to allow customer code to use a fluent builder API without casting, setters in parent classes need to be overriden in child classes, even without adding specific logics.
Note that adding generics to existing classes may also produce warning regarding raw use of generic types.
Guide de contribution
Ouvrir le guide de contribution
Évaluation
Cette issue n'a pas encore été évaluée.