googleapis / googleapis/google-cloud-java

[java-storage-nio] FakeStorageRpc/LocalStorageHelper: leads to logs about needing to call Builder#setApplicationName

Aperta
#12,552 0 commenti 0 reazioni 1 assegnatario Rivendicata da @JesseLovelace Vedi su GitHub
api: storage priority: p3
Lingua principale
Java
Stelle
2.1k
Fork
1.2k
Merge medio
1g 23h
PR unite (30g)
154

Descrizione

#### Steps to reproduce

1. Use LocalStorageHelper at all
2. See log messages needing to call `setApplicationName`

#### Code example

Anything using LocalStorageHelper, eg

```
LocalStorageHelper.customOptions(true).getService().writer(...)
```

ends up running this code in FakeStorageRpc.java

```
public com.google.api.services.storage.Storage getStorage() {
HttpTransport transport = new FakeStorageRpcHttpTransport();
HttpRequestInitializer httpRequestInitializer = request -> {};
return new com.google.api.services.storage.Storage(
transport, new GsonFactory(), httpRequestInitializer);
}
```

This `Storage` constructor creates and then immediately uses a `Storage.Builder`, which means there's no place to call `Builder#setApplicationName`, leading to an unavoidable log.

#### Stack trace

The logged message is:

```
WARN com.google.api.client.googleapis.services.AbstractGoogleClient - Application name is not set. Call Builder#setApplicationName.
```

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.