googleapis / googleapis/google-cloud-java

[java-storage-nio] FakeStorageRpc/LocalStorageHelper: leads to logs about needing to call Builder#setApplicationName

Abierto
#12,552 0 comentarios 0 reacciones 1 asignado Reclamado por @JesseLovelace Ver en GitHub
api: storage priority: p3
Lenguaje dominante
Java
Estrellas
2.1k
Forks
1.2k
Merge medio
1 d 23 h
PR fusionados (30 d)
154

Descripción

#### Steps to reproduce

1. Use LocalStorageHelper at all
2. See log messages needing to call `setApplicationName`

#### Code example

Anything using LocalStorageHelper, eg

```
LocalStorageHelper.customOptions(true).getService().writer(...)
```

ends up running this code in FakeStorageRpc.java

```
public com.google.api.services.storage.Storage getStorage() {
HttpTransport transport = new FakeStorageRpcHttpTransport();
HttpRequestInitializer httpRequestInitializer = request -> {};
return new com.google.api.services.storage.Storage(
transport, new GsonFactory(), httpRequestInitializer);
}
```

This `Storage` constructor creates and then immediately uses a `Storage.Builder`, which means there's no place to call `Builder#setApplicationName`, leading to an unavoidable log.

#### Stack trace

The logged message is:

```
WARN com.google.api.client.googleapis.services.AbstractGoogleClient - Application name is not set. Call Builder#setApplicationName.
```

Guía de contribución

Abrir la guía de contribución

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.