googleapis / googleapis/google-cloud-java
[java-storage-nio] FakeStorageRpc/LocalStorageHelper: leads to logs about needing to call Builder#setApplicationName
- Dominant language
- Java
- Stars
- 2.1k
- Forks
- 1.2k
- Avg merge
- 1d 23h
- Merged PRs (30d)
- 154
Description
#### Steps to reproduce
1. Use LocalStorageHelper at all
2. See log messages needing to call `setApplicationName`
#### Code example
Anything using LocalStorageHelper, eg
```
LocalStorageHelper.customOptions(true).getService().writer(...)
```
ends up running this code in FakeStorageRpc.java
```
public com.google.api.services.storage.Storage getStorage() {
HttpTransport transport = new FakeStorageRpcHttpTransport();
HttpRequestInitializer httpRequestInitializer = request -> {};
return new com.google.api.services.storage.Storage(
transport, new GsonFactory(), httpRequestInitializer);
}
```
This `Storage` constructor creates and then immediately uses a `Storage.Builder`, which means there's no place to call `Builder#setApplicationName`, leading to an unavoidable log.
#### Stack trace
The logged message is:
```
WARN com.google.api.client.googleapis.services.AbstractGoogleClient - Application name is not set. Call Builder#setApplicationName.
```
Contributor guide
Assessment
This issue has not been assessed yet.