googleapis / googleapis/google-cloud-java
[sdk-platform-java] x-goog-api-client is incorrect when the customer uses shading
Đang mở
priority: p3
type: feature request
- Ngôn ngữ chính
- Java
- Star
- 2.1k
- Fork
- 1.2k
- Merge trung bình
- 1 ngày 23 giờ
- Pull request đã merge (30 ngày)
- 154
Mô tả
The current approach pulls the version from the jar manifest. Unfortunately this will break if the application builds an uber jar (the version will come from the uber jar rather then the generated client or gax). A more robust approach would to follow grpc's approach and embed it in a class or to use the maven-resources-plugin. I recently worked around this issue in the bigtable client:
https://github.com/googleapis/java-bigtable/pull/451
Hướng dẫn đóng góp
Đánh giá
Issue này chưa được đánh giá.