googleapis / googleapis/google-cloud-java
[sdk-platform-java] x-goog-api-client is incorrect when the customer uses shading
Aperta
priority: p3
type: feature request
- Lingua principale
- Java
- Stelle
- 2.1k
- Fork
- 1.2k
- Merge medio
- 1g 23h
- PR unite (30g)
- 154
Descrizione
The current approach pulls the version from the jar manifest. Unfortunately this will break if the application builds an uber jar (the version will come from the uber jar rather then the generated client or gax). A more robust approach would to follow grpc's approach and embed it in a class or to use the maven-resources-plugin. I recently worked around this issue in the bigtable client:
https://github.com/googleapis/java-bigtable/pull/451
Guida per i contributori
Apri la guida per i contributori
Valutazione
Questa issue non è ancora stata valutata.