googleapis / googleapis/google-cloud-java

[sdk-platform-java] Add showcase testing for logging on stream cases

Aperta
#12,395 1 commento 0 reazioni 0 assegnatari Vedi su GitHub
priority: p2 type: process
Lingua principale
Java
Stelle
2.1k
Fork
1.2k
Merge medio
1g 23h
PR unite (30g)
154

Descrizione

Basic logging testing are included in https://github.com/googleapis/sdk-platform-java/pull/3403 for unary calls.
Test cases are missing for server side streaming, client side streaming and bidi-streaming.

We need more test coverage for logging behaviors on other type of calls beside unary calls.

Also, consider refactor showcase test to not depend on a TestAppender, but rather capture log outputs from console. This will allow logging implementation classes like GrpcLoggingInterceptor to be not public.

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.